Ignoring more rule types when parsing, updating api, and updates to package.json v4

BlessCSS / bless

CSS Post-Processor

blesscss.com

MIT License

282 stars 60 forks source link

Ignoring more rule types when parsing, updating api, and updates to package.json v4 #44

Closed aabenoja closed 9 years ago

aabenoja commented 9 years ago

Ignoring keyframes, font-faces, and imports when parsing. These will not impact the selector limit. Although test coverage for keyframes have been added, the feature is not supported below IE10.
require('parser') does not make sense for modules that consume bless.js. Renaming parser back to bless, with parser being exported in an object.
Using prepublish, which executes a build script after npm install

adam-lynch commented 9 years ago

Ignoring keyframes, font-faces, and imports when parsing. These will not impact the selector limit. Although test coverage for keyframes have been added, the feature is not supported below IE10.

@aabenoja got a source to back this up? :smile:

aabenoja commented 9 years ago

@adam-lynch Font-faces don't have selectors. Imports have a separate limit (31 according to this blog post). Keyframes don't use css selectors.

adam-lynch commented 9 years ago

@aabenoja ah yeah ok, must've misread the original comment. Thanks.

Maybe @supports should be ignored. It doesn't even work in IE, but could be in the file I guess.

aabenoja commented 9 years ago

@adam-lynch I didn't even know that rule existed. I think I might be better off modifying the else to auto-ignore these cases.These empty case blocks are adding up. On the other, it's nice to be explicit.

aabenoja commented 9 years ago

Opting for an explicit ignore on @supports, making it easier to revisit later.

aabenoja commented 9 years ago

Will most likely defer this to #45

paulyoung commented 9 years ago

I'd like to investigate more before ignore certain parts of the AST.

There was some subtle nuances in previous versions to avoid splitting files in the middle of blocks and that sort of thing.