BlesseNtumble / GalaxySpace

Addon for GalactiCraft 4
Apache License 2.0
68 stars 42 forks source link

(2.0.14) Sublight Engine not installing on fueled rocket #487

Open free-muffin opened 4 years ago

free-muffin commented 4 years ago

Do not remove this template, without it your issue will not be considered!

Please fill in the form below:

  1. Minecraft version: 1.12.2
  2. Galacticraft version: 4.0.2.280
  3. GalaxySpace version: 2.0.14
  4. AsmodeusCore version (for 2.0.1 version and above): 0.0.17
  5. Side (Single player (SSP), Multiplayer (SMP), or SSP opened to LAN (LAN)): SMP
  6. Other add-ons:

    Description of the issue: sublight engine will not install on a t6 rocket with fuel in it


Screenshot/Video: image


Attached log file (or url on pastebin.com): log shouldn't be necessary for this one, chief


to recreate: grab a t6 rocket, put some fuel in it, then try to install a sublight engine via the modification table

v1993 commented 3 years ago

Worse yet: install an engine onto rocket, put fuel in it, break the rocket and the engine will be lost forever.

GalaxinTM commented 3 months ago

Bumping this issue, this still exists now as of May 24, 2024.

I made a crafting recipe with CraftTweaker to fix this issue for the time being:

recipes.addShapeless("galaxyspace/rocket_tier_6/sublight", <galaxyspace:rocket_tier_6>.withTag({sublight_engine: 1 as byte, modification_count: 0}), [<galaxyspace:rocket_tier_6:*>.marked("rocket"),<galaxyspace:rocket_modules:6>],
function(out, ins, cInfo){
    return ins.rocket.updateTag({sublight_engine: 1 as byte, modification_count: 0});
},null);

https://github.com/BlesseNtumble/GalaxySpace/assets/50661916/301d49d2-d9a3-4fe3-a749-fb5c6153cec6