Facilitator's Details Form

[dbilovd]

Functionalities

• [ ] I can click the Submit button, even without filling any of the form fields. It won't submit the form, however, the button should be disabled and unclickable until the form is at least ready to be submitted
• [ ] The email address field accepts none-email addresses as valid values
• [ ] There is the following console warning when I select a date. Warning: A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component....:
• [ ] The submit functionality fails, however, I am navigated to the Department form page. When there is an error, the error should be displayed on the screen and not go to the next page, until the user corrects the error.
• [ ] The form data is posted to the console log before/after submission, it should not be. When debugging, it is fine but should not be committed to Git.
• [ ] There is no place to configure a different API endpoint. This should be available somewhere in the code.

Code

• [ ] The EmployeesAppraisal.jsx component is redundant it only wraps <NewAF /> in a div. I know it was refactored from the old use which had the wizard. Now that it is no longer being used like that, it should be removed, or used instead of <NewAF />.
• [ ] Also the component contains the Facilitator Details Form, but the components are named EmployeesAppraisal and NewAF. Kindly change the name of the file so that it will accurately tell when the file does.
• [ ] This line should only happen AFTER you have sent the form to the server and received a successful response back.https://github.com/BlessingLartey/GaiaCare/blob/ec19a8849305c91ed9d76ff24adaac09d9634847/src/components/NewAF.jsx#L28
• [ ] Let use look at switching this to using an array instead of typing the values directly here. https://github.com/BlessingLartey/GaiaCare/blob/ec19a8849305c91ed9d76ff24adaac09d9634847/src/components/NewAF.jsx#L100-L103
• [ ] Not Important Now: Let us look at moving this block of code which places a call to the API into its file as a function and then, import and use that function here. https://github.com/BlessingLartey/GaiaCare/blob/ec19a8849305c91ed9d76ff24adaac09d9634847/src/components/NewAF.jsx#L31-L40

[BlessingLartey]

Taking notes. Thanks

On Sat, May 25, 2024, 7:52 PM David Lartey @.***> wrote:

Functionalities

• I can click the Submit button, even without filling any of the form fields. It won't submit the form, however, the button should be disabled and unclickable until the form is at least ready to be submitted
• The email address field accepts none-email addresses as valid values
• There is the following console warning when I select a date. Warning: A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component....:
• The submit functionality fails, however, I am navigated to the Department form page. When there is an error, the error should be displayed on the screen and not go to the next page, until the user corrects the error.
• The form data is posted to the console log before/after submission, it should not be. When debugging, it is fine but should not be committed to Git.
• There is no place to configure a different API endpoint. This should be available somewhere in the code.

— Reply to this email directly, view it on GitHub https://github.com/BlessingLartey/GaiaCare/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARZRNRKEIPO2WXPJIMV5OYLZEDTYPAVCNFSM6AAAAABIJELS42VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTOMRQGUZDCOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>