search

Bletch1971 / PixelmonInformation

This extension adds additional Information (via tooltips, Jei and Waila) for use with Minecraft mod - Pixelmon.
3 stars 3 forks source link

The One Probe - Show When Sneaking option not working correctly #17

Closed MattyIceee closed 2 years ago

MattyIceee commented 4 years ago

Describe the bug When The One Probe - Show When Sneaking option is turned on the extra information is not shown when sneaking. However when the option is turned off all the information is shown correctly all the time, as expected (see screenshots)

To Reproduce Steps to reproduce the behavior:

  1. Be sure to have just The One Probe, Optifine, Pixelmon and Pixelmon Information installed
  2. Be sure to have The One Probe - Show When Sneaking option turned on
  3. Start singleplayer game and look at pokemon while sneaking
  4. See that pokemon extended information does not show up
  5. Change The One Probe - Show When Sneaking off
  6. look at pokemon normally and see that the information is shown correctly

Expected behavior The same information that is shown when 'Show When Sneaking' is off should be shown when the option is turned on but only when sneaking (right now it's not at all when the option is enabled, sneak or not)

Screenshots option enabled 2020-10-14_00 15 03

The One Probe while sneaking 2020-10-14_00 15 21

option disabled 2020-10-14_00 15 00

The One Probe looking at pokemon 2020-10-14_00 14 44

Mod Information (please complete the following information):

Additional context This mod is under-rated keep up the good work!!!

Bletch1971 commented 4 years ago

Thank you for the feedback, glad someone likes it 👍

As for the sneak issue, there are options that TOP set using it's own book. I do not remember the three options, but one of them may be needed to turn on while sneaking.

I will check out the code and report back.

Bletch1971 commented 4 years ago

I just checked the code logic and found this

if (ModConfig.top.useSneaking == true && ProbeMode == NORMAL) { // do not show the information in TOP, just return empty }

I cannot for the life of me remember why I added this check. I do not use TOP, but I think it had something to do with the TOP settings.

Maybe play around with the three TOP settings via it's own book and see if they are shown when you change it.

MattyIceee commented 4 years ago

Will do. Also completely forgot I actually installed Vivecraft-NOVR or whatever it was called which pretty much just installs optifine into the minecraft jar file (not that i think this would break your mod just something to keep in mind). I'll take a look thanks!