BleuBleu / FamiStudio

FamiStudio NES Music Editor
MIT License
1.59k stars 100 forks source link

App data path does not follow XDG specification #341

Open dogtopus opened 1 month ago

dogtopus commented 1 month ago

I noticed that the app data path on Linux seems to be explicitly defined to be located at ~/.config/FamiStudio instead of following the XDG specification. This caused the Flatpak version to not follow the standard per-app configuration scheme and leaves private app data behind when uninstalling the app even when the user chose to explicitly delete all app data. This also makes sandbox opt-in (i.e. disable home access and only allow access to a user-defined data directory e.g. xdg-documents/FamiStudio) slightly more difficult.

I believe the fix would simply be using Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), "FamiStudio") as the app data path instead.

BleuBleu commented 1 month ago

Thats a good point, ill make a note of it for 4.3.0.

-Mat