Closed TheJena closed 6 years ago
Hi, thanks for your contribution! Great features, nice :) But please expect that I will change some things to my liking.
Here is what I changed:
Temporary recording files are now hidden. I think it's better because so you can use Ctrl+A in your filemanager to select all, but only sucessfull recordings. Not finished recordings will stay hidden.
Recordings with the --tmp-file option are now not renamed anymore when the user stops the script
Restored default filepattern
Renamed "{track}" to "{trackNumber}" again, because I want to have the same name as the metadata had
Changed the categories of your newly added log messages they shouldn't be infos both
Edited README text a little for example to not use the --debug option by default
I think this is better now for the most users. I hope you are also ok with it ;) Again, many thanks for contribution! (never thought that the first contribution would be that fast and big)
EDIT: Version 0.7.0 got released! Happy testing! :D
Wonderful! Do you mind if in the next pull request I also:
I am also adding an option to encode the final file in libvorbis-ogg with a given quality.
To the code formatting: I will try to do it a little better somewhen, but for now you can let it as it is. I know, some names etc. are not that usual for python, but that's because this is my first real python project and I come from Java ;) EDIT: Thought again about it. If it doesn't take you to much time, you can do it. But this has not high priority! And if you do it, please make another pull request and not everything in one. So I can still look at it and think about if I will merge it or not.
To the encode thing: I already thought about it. But dropped the idea, because: The Spotify listener is not 100% exactly. Sometimes it already triggers a song change during the last song still plays. So we don't exactly know, where a song starts, and where it ends. That's why I seek to the beginning of the song everytime a recording starts and record a little longer after the song change, so that nothing is missing in the recording of the song before. So it sometimes happens, that we have some silence at the beginning of the recording, and also a little of the next song at the end of the recording. I guess nobody wants this. That's why I use Audacity to edit the recordings after recording. And from Audacity, you can export to whatever you want: ogg, mp3... So since manual editing is needed anyway, encoding to such a format within the script would make not much sense. At least not as long as we don't know how to get the exact time of the song start and end. Maybe a note in the README, which recommends the users to use Audacity, would be enough already.
Hi, I add two features:
And improved the documentation in the readme
Thank you for the great job you did writing the initial python script! Bye, TheJena