Open lucyllewy opened 5 years ago
Please note that the game assets are not under MIT. If they're contained in your snap, please relabel the license as CC-BY-NC, and abide by the requirements for that license.
oops, thanks for the pointer. I've done that now :-) /me hopes nobody noticed :-p
Thanks, but could you also note the origin on the content, e.g. by linking to this repo as well as your fork?
done.
Although possibly worth mentioning here that I've not forked this repo to create the package; the snap builder uses this repository directly as defined by the snapcraft.yaml on line 32
(edited to change link - I've moved the repo into a new organisation to collate all the snaps I've made...)
My mistake! Thanks for those quick changes!
I notice that you do some patching of the build. I personally encountered some build errors and had to make some changes in order to get it to build on my Ubuntu 18.04 system. Frankly, I'd be surprised if the linux build could work out of the box for anyone.
The minimum required changes (at least for the versions of components on my system) seem to be in source/linux/Makefile, modify the recipe for generating $(BINDIR)/$(BIN) so that it uses $(CXX) instead of $(CC), and move $(LDFLAGS) so that it's after $(LIB_FILES).
I made some other changes, but they were mostly style/readability/cleanup type changes. I replaced all instances of $(CC) $(CXXFLAGS) with $(CXX) $(CXXFLAGS), and eliminated the "ifndef CC/CC = g++/endif", since GNU Make defines CC by default, and sets it to "cc", so this was dead code.
Works great! Thanks!
Hello @ThyReaper
Can you let me know what are the requirements to include if we want to distribute precompiled binaries of this game?
I think you just need to include the COPYING file in some form (by default, I'd go with 'copyright.txt' or 'license.txt'), and you either need to remove all sounds and graphics or distribute it non-commercially.
doesn't works on Fedora
chmod: changing permissions of './bin/lin64/StarRuler2.bin': Read-only file system
Initializing sound
Initializing window system
Caught Segfault at 0xc
Stack trace:
./bin/lin64/StarRuler2.bin() [0x56ad48]
./bin/lin64/StarRuler2.bin() [0x56adcc]
/lib/x86_64-linux-gnu/libc.so.6(+0x354b0) [0x7f64bdab44b0]
./bin/lin64/StarRuler2.bin() [0x4947ba]
./bin/lin64/StarRuler2.bin() [0x42086f]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7f64bda9f830]
./bin/lin64/StarRuler2.bin() [0x428279]
No active script context to log.
[1] 28487 abort (core dumped) starruler2
To be fair mostly snaps never work out of ubuntu
I can't figure out how to add in the music files from my Steam install of the game into the snapped Star Ruler 2. Attempting to put them directly into the /snap/starruler2/blahblahblah/data folder is impossible, because it is a read-only directory.
Getting the same segfault on ubuntu 18.04 so something is just wrong, we need a flatpak of this. Snaps suck :(
I too would like to know how to add custom music / orchestra.txt stuff to an already installed snap, but the tutorials I found do not cover that topic.
Apparently there's a bunch for CC-by-NC music available for starruler2, maybe this could be included in the snap or added as a separate one if possible?
Replacement music: https://opengameart.org/content/star-ruler-2-replacement-music
Example app for creating the orchestra.txt file: https://github.com/powercat/Star-Ruler-2-Orchestra.txt-generator
This is my first snap usage "evar" so I'm sorry about my ignorance :)
Thanks & keep up the good work, Uwe
Ok, figured out the segfault. I got it when I was running on wayland.
See https://snapcraft.io/starruler2 for details.
To install run:
If you don't have snapd installed then there's documentation about how to get it at https://snapcraft.io/docs/core/install