search

BlinkDL / RWKV-LM

RWKV is an RNN with transformer-level LLM performance. It can be directly trained like a GPT (parallelizable). So it's combining the best of RNN and transformer - great performance, fast inference, saves VRAM, fast training, "infinite" ctx_len, and free sentence embedding.
Apache License 2.0
12.32k stars 838 forks source link

Add typing for latest versions compatibility #96

Open AlexKay28 opened 1 year ago

AlexKay28 commented 1 year ago

Added explicit typing into "bf16" condition usage section.

I have seen a lot of messages in discord chats and struggled personally with this. This PR doesn't change anything in functionality, but just makes code more clear and friendly to the older versions of torch packages

BlinkDL commented 1 year ago

It works if you use deepspeed==0.7.0 pytorch-lightning==1.9.2 please try :)

AlexKay28 commented 1 year ago

@BlinkDL yes, it works, i knew it :) But I noticed you don't provide in the project requirements.txt file or something + it might be not possible to install needed versions in some environments, so I decided to add this typing to avoid such kind of problems.

Feel free to close this issue without applying changes if you think it's redundant, but I have seen some messages from people with this problem :/ I just thought it could make the code safer and that's it)