BlinkID / blinkid-capacitor

ID scanning for cross-platform apps built with Capacitor.
11 stars 3 forks source link

What is the minimum deployment target? #19

Open louisdebaere opened 3 years ago

louisdebaere commented 3 years ago

The minimum deployment target for iOS was recently changed to iOS 12 in the .podspec file, does that actually mean that plugin no longer supports iOS 11 projects?

The version in the native iOS pod says iOS 9, is that the correct indicator?

mparadina commented 3 years ago

Hi @louisdebaere

Yes, you are correct. The minimal deployment target has been updated to iOS 12 due to some dependencies required from Capacitor.

The minimal deployment target for native BlinkID still remains 9.0.

Let us know if you have any additional questions.

Regards, Milan

louisdebaere commented 3 years ago

Our minimum deployment target is iOS 11 so we're unable to update to this version, and we also noticed the plugin now requires Capacitor 3 which we don't support yet. It contains a breaking change in the native iOS code. Could you revert this and add back compatibility with version 2.4 of Capacitor, as advertised in the package.json?

mparadina commented 3 years ago

Hi @louisdebaere

Just to double-check, from the comment you've made here, you were able to make a workaround and fix the issue on your side?

Regards, Milan

louisdebaere commented 3 years ago

It's not an acceptable workaround, we forked this repo made and changes to the plugin implementation as a temporary fix. To support upgrades in the long term, we would require official support for Capacitor 2 and a correct list of dependencies in the package.json.

mparadina commented 3 years ago

Hi @louisdebaere

Unfortunately, we do not plan to support Capacitor 2 with the newer version of the SDK. The only solution to officially have support for Capacitor 2 is to downgrade to the latest version of the SDK which supports it, which is version 5.11.0.

Let us know if you have any additional questions.

Regards, Milan