BlinkID / blinkid-react-native

ID scanning for cross-platform apps built with ReactNative.
172 stars 59 forks source link

Support for localisation in react-native wrapper? #187

Closed msegers closed 2 years ago

msegers commented 2 years ago

Hi, maybe somewhat of a question, but how is the support for overriding the localisation in BlinkID using react native? We noticed the german translations are pretty formal, and our app communicates in a very informal matter, ideally we'd like to override a few strings.

If I'm not mistaken this currently would require us to edit some files which are currently auto generated?

https://github.com/BlinkID/blinkid-android#-translation-and-localization

msegers commented 2 years ago

Actually it seems like you allow overrides outside the module, I'll see if I can get something working

anjapenic commented 2 years ago

Hi @msegers,

Apologies for a late reply! Have you tried setting the strings here - https://github.com/BlinkID/blinkid-react-native/blob/master/BlinkID/overlays/blinkidOverlays.js? If so, please let us know if it helped.

Best regards, Anja

msegers commented 2 years ago

Thanks! will try that! Didn't see it in the readme! We noticed our language overrides wasn't working on our production app (it works fine in our staging/development apps which have the same logic). Worst case scenario we can override all strings this way, will try soon!

msegers commented 2 years ago

It works absolutely fine, thanks!