search

BlinkTagInc / gtfs-to-html

Build human readable transit timetables as HTML or PDF from GTFS.
https://gtfstohtml.com
MIT License
183 stars 56 forks source link

Option to automatically remove empty rows #90

Closed campagnaagtt closed 4 years ago

campagnaagtt commented 4 years ago

We've notice that there are not present an efficient algorithm to merge the nodes of all route's branches in one merged with a correct sequence. So we putting all nodes for all branches in the timetable_stop_order ordered by branches length. Would be helpful remove all empty rows (means with not transit time) on a timetable. You can do it by a true/false option.

brendannee commented 4 years ago

Could you share with me a link to your GTFS and the timetable_stop_order.txt you are using so I can see the empty rows you are talking about?

campagnaagtt commented 4 years ago

Hello, here you can download our GTFS: http://www.gtt.to.it/open_data/gtt_gtfs.zip

Try to use the timetable files attached with route 1085E and all nodes puts in the timetables_stop_order file. I applied a possibile fix in node_modules\gtfs-to-html\views\timetable\timetablepage_full.pug: block extraHeader script(src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js" integrity="sha256-9/aliU8dGd2tb6OSsuzixeV4y/faTqgFtohetphbbj0=" crossorigin="anonymous") if config.removeEmptyRows script. $( document ).ready(function() {
$('tr').filter( function(){ return $(this).find('td.stop-time').length == $(this).find('td.skipped').length; }).not(':first').hide(); });

If not use the timetable_order file, the logic of keep nodes it wrongs. Thanks a lot for your support. Regards

campagnaagtt commented 4 years ago

Hello, here you can download our GTFS: http://www.gtt.to.it/open_data/gtt_gtfs.zip

Try to use the timetable files attached with route 1085E and all nodes puts in the timetables_stop_order file. I applied a possibile fix in node_modules\gtfs-to-html\views\timetable\timetablepage_full.pug: block extraHeader script(src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js" integrity="sha256-9/aliU8dGd2tb6OSsuzixeV4y/faTqgFtohetphbbj0=" crossorigin="anonymous") if config.removeEmptyRows script. $( document ).ready(function() { $('tr').filter( function(){ return $(this).find('td.stop-time').length == $(this).find('td.skipped').length; }).not(':first').hide(); });

If not use the timetable_order file, the logic of keep nodes it wrongs. Thanks a lot for your support. Regards

Alessandro Campagna GTT – Gruppo Torinese Trasporti Sistemi Informativi e Innovazione Tecnologica Sistemi per l’Esercizio Corso Bramante 66, 10126 Torino (TO) Tel: +39 3482729331 Email: campagna.a@gtt.to.itmailto:campagna.a@gtt.to.it

Da: Brendan Neemailto:notifications@github.com Inviato: domenica 20 settembre 2020 05:49 A: BlinkTagInc/gtfs-to-htmlmailto:gtfs-to-html@noreply.github.com Cc: Campagna Alessandromailto:Campagna.A@gtt.to.it; Authormailto:author@noreply.github.com Oggetto: Re: [BlinkTagInc/gtfs-to-html] Option to automatically remove empty rows (#90)

Could you share with me a link to your GTFS and the timetable_stop_order.txt you are using so I can see the empty rows you are talking about?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/BlinkTagInc/gtfs-to-html/issues/90#issuecomment-695636044, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMYYPIYDQS6GRA5J22TPPLLSGV3ANANCNFSM4RS72VOA.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/BlinkTagInc/gtfs-to-html/issues/90#issuecomment-695636044", "url": "https://github.com/BlinkTagInc/gtfs-to-html/issues/90#issuecomment-695636044", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

brendannee commented 4 years ago

Can you upload the timetable_stop_order.txt file you are using to this github issue so I can try building the timetables?

campagnaagtt commented 4 years ago

Hi, check the comment there's the download link: https://we.tl/t-Vn6voUX7wt Thanks a lot Regards

Alessandro Campagna GTT - Sistemi Informativi E Tecnologie Corso Bramante, 68, 10126 Torino TO Tel. +39 0115764216<tel:+39%200115764216> (Int. 2216) Cel. +39 3482729331<tel:+39%203482729331> Mail campagna.a@gtt.to.itmailto:campagna.a@gtt.to.it http://www.gtt.to.it http://www.gtt.to.it/

-------- Messaggio originale -------- Da: Brendan Nee notifications@github.com Data: 21/09/20 05:19 (GMT+01:00) A: BlinkTagInc/gtfs-to-html gtfs-to-html@noreply.github.com Cc: Campagna Alessandro Campagna.A@gtt.to.it, Author author@noreply.github.com Oggetto: Re: [BlinkTagInc/gtfs-to-html] Option to automatically remove empty rows (#90)

Can you upload the timetable_stop_order.txt file you are using to this github issue so I can try building the timetables?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/BlinkTagInc/gtfs-to-html/issues/90#issuecomment-695883287, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMYYPI7HNTJ5JGA43EDFUE3SG3A2TANCNFSM4RS72VOA.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/BlinkTagInc/gtfs-to-html/issues/90#issuecomment-695883287", "url": "https://github.com/BlinkTagInc/gtfs-to-html/issues/90#issuecomment-695883287", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

brendannee commented 4 years ago

Thanks,

I checked out the timetables that are getting generated using the GTFS and timetable_stop_order.txt.

Since you are specifying the stops to be displayed in timetable_stop_order.txt, you can just exclude any stops which have no timepoints from timetable_stop_order.txt. I made an updated timetable_stop_order.txt which removes all of the stops which didn't have stop times from that route - you can grab it here timetable_stop_order.txt

and it generated

Screen Shot 2020-09-20 at 11 35 30 PM
campagnaagtt commented 4 years ago

Thanks! Anyway your output is not exhaustive. In the your with solution you’ve proposed the trips are truncated. It should be as: [cid:image001.png@01D68FF4.11467270]

Another issue I’ve encountered is that for first timetable are not printed the dayList in the tripName. I resolved modifying the formatTripName funztion. Could you check this too. Thanks a lot for your support. Regards, AC

Da: Brendan Nee notifications@github.com Inviato: lunedì 21 settembre 2020 08:37 A: BlinkTagInc/gtfs-to-html gtfs-to-html@noreply.github.com Cc: Campagna Alessandro Campagna.A@gtt.to.it; Author author@noreply.github.com Oggetto: Re: [BlinkTagInc/gtfs-to-html] Option to automatically remove empty rows (#90)

Thanks,

I checked out the timetables that are getting generated using the GTFS and timetable_stop_order.txt.

Since you are specifying the stops to be displayed in timetable_stop_order.txt, you can just exclude any stops which have no timepoints from timetable_stop_order.txt. I made an updated timetable_stop_order.txt which removes all of the stops which didn't have stop times from that route - you can grab it here timetable_stop_order.txthttps://github.com/BlinkTagInc/gtfs-to-html/files/5253757/timetable_stop_order.txt

and it generated

[Screen Shot 2020-09-20 at 11 35 30 PM]https://user-images.githubusercontent.com/96217/93738194-0673a900-fb9a-11ea-8265-56cea2ab82ab.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/BlinkTagInc/gtfs-to-html/issues/90#issuecomment-695929459, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMYYPI6XD32R7WFR52Q2SVTSG3X7HANCNFSM4RS72VOA. [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/BlinkTagInc/gtfs-to-html/issues/90#issuecomment-695929459", "url": "https://github.com/BlinkTagInc/gtfs-to-html/issues/90#issuecomment-695929459", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

brendannee commented 4 years ago

You should be able to put in the full list of stop_ids in timetable_stop_order.txt so that all stops with timepoints show up on the timetable, in the order that you want them to show up. You may need to add more stops to timetable_stop_order.txt so that the timetable is complete. For routes where all trips make exactly same stops, you don't need to specify stops in timetable_stop_order.txt.

Can you share with me your modifications for putting dayList in the tripName?

brendannee commented 4 years ago

I pushed an update to the documentation to better explain the purpose of timetable_stop_order.txt file https://gtfstohtml.com/docs/timetable-stop-order. Check it out and let me know if you have suggestions for how to make it easier to understand.

brendannee commented 4 years ago

Closing this issue - feel free to reopen or comment as needed.