search

Blinkinlabs / ch554_sdcc

CH554 software development kit for SDCC
297 stars 70 forks source link

make some functions inline #22

Closed nerdralph closed 4 years ago

nerdralph commented 4 years ago

reduces code size when functions are not used

nerdralph commented 4 years ago

I get no build errors with sdcc 3.8.0. I think the failure is due to Travis using sdcc 3.3.0.

cibomahto commented 4 years ago

Makes sense. I'll take a look at updating the CI server to use something more modern. I had it pegged to an old version because they hadn't released a newer binary for Windows, however this is no longer the case: https://sourceforge.net/projects/sdcc/files/sdcc-win64/

cibomahto commented 4 years ago

Updating SDCC fixes the first issue, however it looks like an extra example 'play' was checked in, that doesn't have a proper makefile, so the CI test still fails. You can recreate what the test is doing by going to the 'examples' directory and typing 'make' - on Linux, this should build all of the examples cleanly. It doesn't work on Windows because the 'usb_device_cdc_i2c' example compiles some native code; that should probably be fixed but is a separate issue.

nerdralph commented 4 years ago

Sorry, I forgot to make a new branch after I created the pull request and before I added the new 'play' subdir. Or maybe I could've just tagged my fork before generating the pull request instead of going off master. I'll see what I can do to clean that up.

cibomahto commented 4 years ago

No worries, apologies for taking so long to check it out.

nerdralph commented 4 years ago

I just pushed the removal of the 'play' example. I left an update to the Makefile.include to support different flashing tools. I'm using: export WCHISP="ch55xtool.py -r -f" If you don't set WCHISP, it should work exactly as it did before.

On Sat, Aug 1, 2020 at 4:48 AM Matthew Mets notifications@github.com wrote:

No worries, apologies for taking so long to check it out.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Blinkinlabs/ch554_sdcc/pull/22#issuecomment-667490560, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKNZ6USRN27ZXS22LLSAW3R6PCEPANCNFSM4O5LNZ7A .

nerdralph commented 4 years ago

Any more comments?

cibomahto commented 4 years ago

That looks great, thanks!