Blinue / Magpie

An all-purpose window upscaler for Windows 10/11.
GNU General Public License v3.0
9.12k stars 482 forks source link

[Feature request] FSR sharpening textbox or slider #57

Closed virtualbs closed 3 years ago

virtualbs commented 3 years ago

Please add a textbox or slider for controlling the RCAS sharpness in FSR (the default should be 0.2, according to the official docs).

Also, from the same doc:

AU1 const0[4];

FsrRcasCon(const0, Sharpness); //Sharpness in range [0-2], 0 is sharpest

Thank you!

Blinue commented 3 years ago

Magpie provides a way to change the sharpness of FSR. Check out #43

virtualbs commented 3 years ago

Thanks! Does changing the .json takes effect immediately, or should I restart Magpie?

Blinue commented 3 years ago

In v0.5.2, you have to restart Magpie.

virtualbs commented 3 years ago
RCAS Sharpening

Values above 1.0 in the .json are giving me errors in Magpie, so I take it I am effectively changing 'Sharpness' and not 'RCAS Sharpness' stops, correct?

Thanks

Blinue commented 3 years ago

'RCAS Sharpness' = 2 - 'sharpness' * 2

virtualbs commented 3 years ago

Thanks, I've also checked https://github.com/Blinue/Magpie/wiki/%E8%87%AA%E5%AE%9A%E4%B9%89%E7%BC%A9%E6%94%BE and it was already detailed there.

Increasing RCAS strength and adding a step of CAS afterwards was just what I needed. Thank you for structuring ScaleModels like that, as a series of stacked effects. 👍

Blinue commented 3 years ago

Have fun