Closed 7Brandyn7 closed 1 year ago
While this is a convenient option, I would like to decouple the UI from the specific scaling effect. Users may delete, modify, or rename FSR effect, and I'm not sure when this option should be available.
If you need this feature, please implement it in your own branch.
@Blinue What if you just do it for sharpening in general. Or just have it appear only on the settings that have Sharpness.
I am new to programming so I don't really know how to edit the json file with a slider.
There are countless combinations of zoom effects, for example:
[
{
"module": "FFX",
"effect": "FsrEasu",
"scale": [ -1, -1 ]
},
{
"module": "FFX",
"effect": "FsrRcas",
"sharpness": 0.5
},
{
"module": "FFX",
"effect": "CAS",
"sharpness": 0.5
}
]
There are two sharpening effects here, which one should be adjusted by this option?
I would say it should do both.
This makes too many assumptions. I don't think you can adjust ScaleModels with a simple parameter. The best solution is to create a UI for the whole ScaleModels, but for now you can only adjust it by editing ScaleModels.json.
The best solution is to create a UI for the whole ScaleModels
It would be super nice to have this. I've tested some game with this:
"module": "FFX",
"effect": "CAS",
"sharpness": 0.3
},
{
"module": "FFX",
"effect": "FSR",
"sharpness": 0.3
}
and without this, game looks better without this in the end.
You can try as much as you like to find the one that suits you best
can u guys tell me what is the difference between cas and fsr sharpness effect, i couldnt understand I watched @7Brandyn7 video but i didnt understand the difference between both which is executed when u upscale by hotkey? I made a video on my channel, mythtech abt magpie but saw brandyns video after it I need some info on cas vs fsr please, since both go under ffx module thanks in advance
Also, i did notice performance improvements, but I think its because my cpu is suuuuper strong, since it uses alot of cpu
FSR and CAS are completely different. CAS is a sharpening algorithm, and FSR is a scaling algorithm. FSR itself contains a sharpening step. If you think that FSR is not sharp enough, you can add another sharpening step afterwards, such as CAS.
Would be nice to have FSR presets too like in this program https://store.steampowered.com/news/app/993090/view/2957161686744542612
Implemented in v0.10 🎉
Right below the options would be a great one.
It just has to change the sharpness to a 0-10 slider then divide by 10