Blinue / Magpie

An all-purpose window upscaler for Windows 10/11.
GNU General Public License v3.0
9.16k stars 484 forks source link

Adding CRT Guest Advanced as effect #860

Open Jobima1st opened 6 months ago

Jobima1st commented 6 months ago

Expected behavior 预期的功能

Hi In case you don't know "CRT Guest Advanced" is the most advanced CRT shader that still get updates so it will be nice if it ported to Magpie

Also there are ntsc-adaptive to port as another option to use since there are only GTU_v050 in Magpie now

Alternative behavior (optional) 近似的功能(可选)

No response

Blinue commented 6 months ago

CRT Guest Advanced: https://github.com/libretro/slang-shaders/blob/master/crt/crt-guest-advanced.slangp NTSC-Adaptive: https://github.com/libretro/slang-shaders/blob/master/ntsc/ntsc-adaptive.slangp

These shaders look quite impressive, yet they’re also complex. It would be great to integrate them into Magpie. Thank you for your recommendation!

GitHub
slang-shaders/crt/crt-guest-advanced.slangp at master · libretro/slang-shaders
Contribute to libretro/slang-shaders development by creating an account on GitHub.
GitHub
slang-shaders/ntsc/ntsc-adaptive.slangp at master · libretro/slang-shaders
Contribute to libretro/slang-shaders development by creating an account on GitHub.
Jobima1st commented 6 months ago

I just noted this https://github.com/SnowflakePowered/librashader this should make all retroarch shaders run without any edit rather than port them one by one

GitHub
GitHub - SnowflakePowered/librashader: RetroArch Shaders for All
RetroArch Shaders for All . Contribute to SnowflakePowered/librashader development by creating an account on GitHub.
Blinue commented 6 months ago

The project was discussed in #785. Magpie has its own shader syntax, which is simple and efficient. Introducing a large third-party dependency may not be worthwhile.