search

Blinue / Magpie

An all-purpose window upscaler for Windows 10/11.
GNU General Public License v3.0
9.56k stars 493 forks source link

Magpie stops scaling the game window #959

Open rampaa opened 4 months ago

rampaa commented 4 months ago

Magpie version 程序版本

0.11.1

Windows version 系统版本

Windows 10 22H2

Related screenshot (optional) 相关截图（可选）

https://github.com/Blinue/Magpie/assets/25622653/2fbe86f9-d74b-4665-afff-f592b5486b05

Reproduction steps 复现步骤

1) Install https://vndb.org/r37327 2) Add a profile for the game and enable the "Auto scale when in foreground" option. 3) Skip until you see the first option in the game. After the first option, any time an in-game "video" ends, Magpie stops scaling the game window and does not start re-scaling it again without game window losing and re-gaining the focus.

I tried to change the following settings but they didn't solve the problem: "Capture method", "3D game mode", "Disable window resizing while scaling", "Capture title bar", "Disable DirectFlip".

Log files 日志文件

magpie.log

rampaa commented 4 months ago

In case it's useful: Magpie v0.9.1 auto re-scales the aforementioned game's window after it stops scaling it. v0.10.0 onwards though it doesn't, as shown in the video.

Blinue commented 4 months ago

Where can I get a copy of the game? It looks like there's a trial version available, but I can't find the download link.

rampaa commented 4 months ago

The trial version can be downloaded from: http://suezou.dyndns.org/dl2011/jellyfish/sisters/SISTERS_PLAYABLE_DEMO.zip

But I can't reproduce the problem with the trial version, it seems pretty different from the Ultra Edition. I can send some links about the Ultra Edition to your e-mail address if you don't mind sharing it.

Blinue commented 4 months ago

I couldn't reproduce the issue with the trial version either. I plan to implement persistent scaling in the future, so I don't want to spend too much time on this issue right now. Thank you for reporting it!

rampaa commented 4 months ago

I plan to implement persistent scaling in the future

What does that entail exactly? Would it also solve https://github.com/Blinue/Magpie/issues/538?

so I don't want to spend too much time on this issue right now

Sounds reasonable, I will just use the Magpie v0.9.1 for this specific game.

Thank you for reporting it!

Thank you for developing this marvelous tool.

Blinue commented 4 months ago

What does that entail exactly? Would it also solve https://github.com/Blinue/Magpie/issues/538?

The plan is to maintain scaling even when switching windows, allowing the scaling window to stay in the background (the scaling window is not top-most anymore). Once implemented, this should resolve all unexpected scaling interruptions. This feature might be introduced alongside windowed mode.

antoniodesousa commented 4 months ago

The plan is to maintain scaling even when switching windows, allowing the scaling window to stay in the background (the scaling window is not top-most anymore). Once implemented, this should resolve all unexpected scaling interruptions. This feature might be introduced alongside windowed mode.

This will be awesome! I'm facing the same issue with multiple games in TeknoParrot (it's an arcade emulator) where the game window is clearly in the foreground but Magpie still doesn't upscale it, unless I use the shortcut to force the window to upscale. Is there an ETA for this new feature to be released? Thanks.