search

BlitterStudio / MB_SubSonic

MusicBee SubSonic plugin
GNU General Public License v3.0
110 stars 14 forks source link

Songs displayed as folders #30

Closed Koenvh1 closed 6 years ago

Koenvh1 commented 6 years ago

I noticed that songs themselves are also displayed as subfolders for an album. An example from the Subsonic demo server can be seen here: image

To Turn Around is a song that belongs to the album Plastic City, but also shows up as folder in the library. Could it be that it checks for the existence of the isDir attribute rather than the value of it?

midwan commented 6 years ago

@Koenvh1 Thanks for reporting this. I'll try to recreate it now that my server is back online (hasn't been working for quite a while) and get back to you.

Koenvh1 commented 6 years ago

You seem to miss an isDir check in the GetFolders function: https://github.com/midwan/MB_SubSonic/blob/master/MB_SubSonic/Subsonic.cs#L307

With that in place it does work as expected: afbeelding

midwan commented 6 years ago

Thanks for the PR, merged! :)

I'll get a new release prepared as soon as I check everything.