BlitterStudio / amiberry

Optimized Amiga emulator for Linux/macOS
https://amiberry.com
GNU General Public License v3.0
664 stars 90 forks source link

Amiberry 5.3 and whdload_db empty lines bug #1013

Closed tomino1983 closed 2 years ago

tomino1983 commented 2 years ago

Describe the bug I noticed that the hardware settings inside the whdload_db are randomly ignored by Amiberry as well as the custom controls.

In order to fix those settings for each ignored setting it is needed to add one empty line before the setting so Amiberry is able to read it.

This happens with almost every game and every setting

Here is an example of my customizations:

    <hardware>
    PRIMARY_CONTROL=JOYSTICK
    PORT0=JOY
    PORT1=JOY
    CPU=68000
    CLOCK=7
    SCREEN_AUTOHEIGHT=FALSE
    SCREEN_HEIGHT=400
    SCREEN_WIDTH=720
    SCREEN_CENTERH=SMART

    SCREEN_CENTERV=SMART
    </hardware>
    <custom_controls>
    joyport1_amiberry_custom_none_leftshoulder=F1

    joyport1_amiberry_custom_none_rightstick=F2
    </custom_controls>"

As you can notice in order to have the settings "joyport1_amiberry_custom_none_rightstick=F2" and "SCREEN_CENTERV=SMART" correctly red and set in amiberry i had to add an empty line before them

Expected behavior Amiberry/Whdload shouldn't have problem to read the whdload_db correctly without the empty lines

Love Amiberry? Please consider supporting our collective: 👉 https://opencollective.com/amiberry/donate

midwan commented 2 years ago

@tomino1983 I can actually recreate this - sorry, I've removed my previous comment.

midwan commented 2 years ago

This is now fixed with the above commit in master - it will be part of the next binary release as well (5.4)