BlitterStudio / amiberry

Optimized Amiga emulator for Linux/macOS
https://amiberry.com
GNU General Public License v3.0
661 stars 89 forks source link

Make "Log to console" stick #1332

Closed solskogen closed 5 months ago

solskogen commented 6 months ago

As of now, there's no way to save the option "Log to console"

midwan commented 6 months ago

That's on purpose, as I don't see any valid reason you'd want this option saved somewhere. It will spam your console when enabled, so it's only really useful for troubleshooting purposes, in which case you'd enable it for the time period you're testing.

I believe WinUAE also follows the same approach on this.

solskogen commented 6 months ago

It doesn't make that much sense on WinUAE, but I think it might do in Amiberry (although not very much needed) and it doesn't make much sense to NOT save that option, but save others.

midwan commented 6 months ago

The option can be triggered from both the console (--log) and the GUI (Paths panel). I don't see any scenario where this would be useful to have in a config file, considering the expected use for it (temporary troubleshooting).

Can you explain what you have in mind, that would require it?

solskogen commented 6 months ago

It's not about what I need, but keeping it consistent. The user would expect it to stick when other options do.

giantclambake commented 5 months ago

/2cents ~ initially, I believed the reason this option was in the Paths panel, was because there was an inference that the Enable logging option had to be enabled first, for it to work...(from #1310 )...

From the GUI, in the Paths panel, you will find a new checkbox (Log to console). Enable this, and the output will also go to the console

...the word 'also' being the culprit ;) Now that I check it, the Log to console option is actually standalone, and doesn't require logging to be enabled to work correctly.

That being the case, and taking a step back to play a game of 'one of these things is not like the others' when looking at the Paths panel, the odd man out is the Log to console option --- it has nothing to do with any file path =)

Given the niche usage case the folks over at TASVideo requested this option for, (and likewise they haven't come back to ask if this option could be persistent), and thinking how 'typical' amiberry users would 'normally' be using the logfile creation feature, I would wonder how many of them might enable log to console....just because that option is there =)

For mine, I would argue the Log to console option has very little to do wrt being a logging option, and certainly nothing to do with Paths, and given the motivation that led to it's implementation, what it really is... is ' a specific emulator option that doesn't fit in any other panel'... and that's why it should be in the Miscellaneous panel instead, because if anything I'd classify it as being a 'developer option' as it were ..which is really what it is ;) From there, it might be saved to a config.uae as well...

...I'll hedge a bet the folks at TASVideo are on the cmdline ;)

midwan commented 5 months ago

In the original implementation, you had to enable logging in order for this to work. This was changed later, as I found it a bit better this way, but I forgot to update the help text. :)

I also suspect that most people that want to use it, might do so from the console. However, following the general rule to keep the GUI similar to that of WinUAE, I've placed the checkbox there to correspond with the Log window option of WinUAE:

image

That option does not save anywhere in WinUAE either. :)

giantclambake commented 5 months ago

Ahh, thanks for the explanations (I often forget about winuae ;) Precedent is set, moving on... B)