BlitterStudio / amiberry

Optimized Amiga emulator for Linux/macOS
https://amiberry.com
GNU General Public License v3.0
660 stars 88 forks source link

The second fire button only works after opening the GUI when using default.uae #986

Closed Retro1968 closed 2 years ago

Retro1968 commented 2 years ago

Raspberry Pi 4 with RetroPie 4.8. Amiberry 5.2 with AmigaOS 3.2.1

The game Mega Typhoon supports two fire buttons. Sometimes the second fire button works in game, sometimes it doesn't.

In order for the second fire button to work properly again, I have to go into the amiberry GUI with F12 and exit it again immediately.

It was tested with amiberry 5.2 (2022-06-11), which I compiled with this command: make -j4 PLATFORM=rpi4-sdl2, and the precompiled binaries of the RetroPie setup.

default.zip

Cheers Retro1968

P.S.: Since I can't think of any other game that supports two fire buttons, I'm asking for information so I can test it with another game.

iconoclusterdotexe commented 2 years ago

Lionheart and Turrican 3 support a 2-button joystick. You can activate it on game options menu (On Turrican 3 select Joypad)

Retro1968 commented 2 years ago

Lionheart and Turrican 3 support a 2-button joystick. You can activate it on game options menu (On Turrican 3 select Joypad)

Thanks for the hint. I can pinpoint the problem now.

Every time a WHDLoad game is started from my Workbench 3.2.1 after a cold start of amiberry, the second fire button only works if you have previously briefly pressed F12 for the amiberry GUI and then exited it immediately. As long as amiberry is running you can run any other WHDLoad game; the second fire button works... until you exit amiberry... then the problem starts all over again.

I tested this with Turrican 3, Lionheart, Desert Strike and Mega Typhoon.

Cheers Retro1968

iconoclusterdotexe commented 2 years ago

Seems an sdl2 issue. Reminds me to a similar issue happened to me with Auto Height and an old Amiberry version (4.1.4 or something similar. Fortunately solved with the next version). The screen goes black at game start with Auto Height mode on and when i tried to open and close GUI, it shows the game screen.

midwan commented 2 years ago

Thanks for reporting this - I haven't tried to recreate it yet, but from the description it sounds like some controller option(s) are not applied if the GUI is not opened once. I'll look into it.

midwan commented 2 years ago

@Retro1968 What options have you set in the Input panel, and specifically in Port 1 where your controller is? Have you changed it from the Default mode, for example? I'm trying to narrow down which option(s) are those that are not applied until you open the GUI, as you describe.

Retro1968 commented 2 years ago

@Retro1968 What options have you set in the Input panel, and specifically in Port 1 where your controller is? Have you changed it from the Default mode, for example? I'm trying to narrow down which option(s) are those that are not applied until you open the GUI, as you describe.

I sent you my default.uae and my amiberry.conf

configs.zip

midwan commented 2 years ago

@Retro1968 Thanks, that helps. Could you do one test please? What if you rename your default.uae to something else, and load it when the emulator starts up instead? Perhaps this only happens when using a default.uae file, and not with normal configs otherwise. This one is a little special, since it's auto-loaded on startup.

Retro1968 commented 2 years ago

@Retro1968 Thanks, that helps. Could you do one test please? What if you rename your default.uae to something else, and load it when the emulator starts up instead? Perhaps this only happens when using a default.uae file, and not with normal configs otherwise. This one is a little special, since it's auto-loaded on startup.

No problem, I'm happy to help. :-)

If I rename the default.uae, I get to the GUI first when I start amiberry. After I loaded the renamed default.uae from there, the second fire button works. I tested this with Mega Typhoon.

Cheers Retro1968

PS.: I would like to draw your attention to this issue again, since you have not written anything about it yet: https://github.com/BlitterStudio/amiberry/issues/985

The guru messages have been appearing there since version amiberry 5.2 (2022-06-11). A version before everything ran error-free. So the error would probably be easy to fix since you would only have to look at what changes you made to amiberry.

midwan commented 2 years ago

@Retro1968 should be fixed with bfe936d82a82d55ccbe9bbe3b8b25231c200ebb3 - please verify on your end as well when possible.

Retro1968 commented 2 years ago

Yes, the second fire button issue is solved now. You did very well. Many Thanks!!! :-)