search

BlitzKraft / saythanks.io

Spreading Thankfulness in Open Source.
https://saythanks.io
1.26k stars 153 forks source link

Keyboard shortcut to Accept the default placeholder contents in the note #162

Closed kgashok closed 2 years ago

kgashok commented 2 years ago

In conjunction with #159 will provide comprehensive functionality to #59 topic attribution feature that was added.

  1. By pressing the right arrow, the placeholder contents can be included as part of the note, and then allow user to add some more words...
  2. Include reference to the topic also in the default placeholder contents,
  3. On the mobile, what will be the "touch shortcut" to accept the default placeholder contents?

image

tarunkumark commented 2 years ago

I would like to work on this issue, especially the first feature. As for the second feature, while fixing issue #159, #160 @Pavithratrdev and I will push patches for the corresponding features here as well.

kgashok commented 2 years ago

Well done, @tarunkumark

tarunkumark commented 2 years ago

Thank you sir

kgashok commented 2 years ago

The editor acts quite weirdly! Understandably! Again, another case of inadequate testing of the new feature!

After accepting the placeholder code, the "right arrow" key should only move the cursor. Please fix ASAP!

image

@Pavithratrdev @tarunkumark

kgashok commented 2 years ago

Probably have to implement the keyboard shortcut as a combination of <Ctrl> + <Right Arrow>