BlitzKraft / saythanks.io

Spreading Thankfulness in Open Source.
https://saythanks.io
1.25k stars 154 forks source link

HTML edited notes are getting email'ed but not saved in database #227

Closed kgashok closed 1 year ago

kgashok commented 2 years ago

When choosing HTML as the option, image

The email arrives alright....

image

But it is not getting stored in the inbox database

image

kgashok commented 2 years ago

@tarunkumark - this is yours to take and close. @Pavithratrdev

tarunkumark commented 2 years ago

I have actually done this intentionally. If the HTML message contains any Embedded CSS, it will ruin the CSS of the inbox page.

kgashok commented 2 years ago

I have actually done this intentionally. If the HTML message contains any Embedded CSS, it will ruin the CSS of the inbox page.

In that case, don't allow any CSS based notes to be created? Just plain HTML support will do.

tarunkumark commented 2 years ago

I have actually done this intentionally. If the HTML message contains any Embedded CSS, it will ruin the CSS of the inbox page.

In that case, don't allow any CSS based notes to be created? Just plain HTML support will do.

Ok, I will remove the scripts, styles and other related attributes and store the rest in the inbox.

kgashok commented 2 years ago

Ok, I will remove the scripts, styles and other related attributes and store the rest in the inbox.

Super!

% ashok

On Mon, 20 Jun 2022 at 15:36, Tarun K Kumar @.***> wrote:

I have actually done this intentionally. If the HTML message contains any Embedded CSS, it will ruin the CSS of the inbox page.

In that case, don't allow any CSS based notes to be created? Just plain HTML support will do.

Ok, I will remove the scripts, styles and other related attributes and store the rest in the inbox.

— Reply to this email directly, view it on GitHub https://github.com/BlitzKraft/saythanks.io/issues/227#issuecomment-1160242976, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASJWIX2MEOO64KGJQM26G3VQA7CTANCNFSM5ZGUL4YA . You are receiving this because you authored the thread.Message ID: @.***>