search

BlitzKraft / saythanks.io

Spreading Thankfulness in Open Source.
https://saythanks.io
1.25k stars 154 forks source link

Pagination @adithya14255 @marudhu2004 #275

Closed Adithya14255 closed 2 weeks ago

Adithya14255 commented 2 weeks ago

Fixed #272

I @adithya14255 and @marudhu2004 have done the following:

[x] added the issue number for which this pull request is created. [x] added pagination for inbox [x] ensured that search feature works with the new changes [x] handled bad requests which might come with page count (negative pages, above page limit) by returning 404 [x] added custom 404 page

futher by @adithya14255 [x] pagination with search [x] clear button to remove searched string [x] fixed some issues with using same route for both search and normal [x] fixed some session problems [x] page change only visible when more than 1 page exists [x] fixed issue when new login leads to error page

@Pavithratrdev, please let me know about this update.

kgashok commented 2 weeks ago

image

This is not intuitive. Needs appropriate spacing

kgashok commented 2 weeks ago

image

This was the display when NO PAGINATION was in effect. But when pagination is in progress, this information should be different or presented and formatted differently.

kgashok commented 2 weeks ago

Two additional links required:

  1. To get to the top of the inbox (page 1)
  2. To get to the end of the inbox (last page).
kgashok commented 2 weeks ago

I have given three different suggestions/modifications. Each one of them can be posted as a separate issue, and specific PRs to be generated for each of them.

kgashok commented 2 weeks ago

Number of messages to be displayed per page can be increased to 25

kgashok commented 2 weeks ago

Good speed improvement! Well done @Adithya14255 @marudhu2004 @Pavithratrdev