search

BlitzKraig / fvtt-CommunityLighting

FoundryVTT Community Lighting Animations for 0.7.x+
MIT License
9 stars 6 forks source link

Audio light disabled until sound is played #15

Open Nordiii opened 3 years ago

Nordiii commented 3 years ago

I would love if the audio lights had an option to disable them if no sound is played.

Current behavior: Currently the audio light does light up the scene even when no sound is playing and you dont see its effects.

Wanted behavior: An option so that a light does not light up the scene until audio triggers the light source.

Example: It is a stormy night and only thunderstrikes light up the forest every few seconds the guarding party members could see wolves is creeping near the camp if thunder strikes (or they have dark vision).

BlitzKraig commented 3 years ago

Hi Nordiii,

This is one of the most annoying problems with the new lighting system, there is no good way to completely hide a light without disabling it - at which point, all animations stop.

I found a potential workaround which is live on the Lightning (Experimental) animation, but I don't think it's robust enough. If a player moves at the same time the strike is active, the FoW will be revealed due to the sightUpdate call.

I plan to do some more digging into this, and see if there's some way to improve it. If I can find a solution, I will add the option to the audio-reactive lighting too.

Thanks

Nordiii commented 3 years ago

Well I would not mind the Fog of War going away as they theoretically saw all of it. Just want to hide tokens without really hiding those. Thanks for the info!

Sadly Lightning (experimental) does not have an option to hook up to the sound?

BlitzKraig commented 3 years ago

Correct, Lightning is just a semi-random flash.

This is on my radar. At the very least, I should be able to add the workaround used for lightning to audio-lights as a checkbox option in the next update.

Thanks

YourDNDPleasesMe commented 3 years ago

I just wanted to throw my vote in for this as well. I spent some time trying to sort out what I was doing wrong to make my scene just barely visible to all players... Just found this Issue thread and realized it's the current design.

Love the feature. Big wow factor for players. If there's a way to have the light not show anything when it's in the "off" state it would be perfect.