search

BlitzKraig / fvtt-CommunityLighting

FoundryVTT Community Lighting Animations for 0.7.x+
MIT License
9 stars 6 forks source link

Strange error message when refreshing page or changing scene. #27

Closed zLaddeus closed 3 years ago

zLaddeus commented 3 years ago

Some of my players get this error when refreshing the page or changing scene. I've used Find the Culprit to find that it is the CommintyLightning module that causes it.

image

image

Dunno what causes it. I've tried to remove and install the module, but doesn't change anything.

zLaddeus commented 3 years ago

I created a new world, new actor and new NPC. Only enabled the module, and get the same error.

image

Seems like there is some sort of Permission issue?

I don't get an error if the player is sett to Assistant GM for example.

Kelmey commented 3 years ago

I have the same issue. I created a separate issue for it because I didn't see this one. I'll try to close my duplicate.

Here is what I wrote in my issue.

Foundry 0.7.9 CL version 0.3.1

If I make a token emit light and assign a light animation from this mod an error popup occurs every time a player loads the scene. The error doesn't happen if a GM loads the scene.

I was using the alternate torch, blurred torch, and star light animations. The tokens with the light sources were NPCs, not player tokens. I verified the error doesn't happen if I use no animation, or a default animation.

Here is the error from the console.

foundry.js:3780 Error: User Test Player lacks permission to update Tokens in parent gEd5ruT1uhzaE6oE at Function._onUpdate (D:\Programs\Foundry\FoundryVTT\resources\app\dist\database\odm\embedded.js:1:7985) at runNextTicks (internal/process/task_queues.js:59:5) at processImmediate (internal/timers.js:412:9) at process.topLevelDomainCallback (domain.js:130:23) at async Socket.handleEvent (D:\Programs\Foundry\FoundryVTT\resources\app\dist\sockets.js:1:2262) _handleError @ foundry.js:3780 foundry.js:11476 Uncaught (in promise) Error: User Test Player lacks permission to update Tokens in parent gEd5ruT1uhzaE6oE at Function._onUpdate (D:\Programs\Foundry\FoundryVTT\resources\app\dist\database\odm\embedded.js:1:7985) at runNextTicks (internal/process/task_queues.js:59:5) at processImmediate (internal/timers.js:412:9) at process.topLevelDomainCallback (domain.js:130:23) at async Socket.handleEvent (D:\Programs\Foundry\FoundryVTT\resources\app\dist\sockets.js:1:2262)

Dick-K commented 3 years ago

I'm running Foundry 0.7.9 and Community Lighting 0.3.1 and am getting the same error on a couple of scenes, but not for all scenes or all players, although it is consistent for the scene/player combinations which it does affect.

I've run through all my modules, turning them off one by one. Goes away if I turn off Community Lighting.

BlitzKraig commented 3 years ago

Thanks for all the info everyone. As far as I can tell, this won't cause any actual problems, though it is annoying.

I'll be taking a look at this soon

BlitzKraig commented 3 years ago

I think this might be fixed in the latest updates. Can anyone confirm?

Thanks

Dick-K commented 3 years ago

I've tested this on Foundry 0.8.7 and CL 0.4.6. It happened on a couple of maps the first time I ran through them, activating them one after the other, but I couldn't repeat this in the same session. I rebooted the server and relogged with the player, hasn't happened again. Something's been reset and appears to have done the job. I'll keep an eye on it, but looks to be solved, thanks a lot.

BlitzKraig commented 3 years ago

I've tracked down the reason for the error messages. I can see one place where it might still appear in the latest versions, so I'll make sure to fix that too just in case.

If you do see the message, rest assured it will be fixed in the next update.

Thanks

Kelmey commented 3 years ago

Thanks much for looking into this!

On Mon, Aug 9, 2021 at 8:53 AM Craig C @.***> wrote:

Closed #27 https://github.com/BlitzKraig/fvtt-CommunityLighting/issues/27.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BlitzKraig/fvtt-CommunityLighting/issues/27#event-5130596512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGTTAYYIBKPRAROO6LQXXOLT372W5ANCNFSM4VHO6RGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

BlitzKraig commented 3 years ago

Let me know if you see any more errors like that, they should all be resolved