BlitzKraig / fvtt-CommunityLighting

FoundryVTT Community Lighting Animations for 0.7.x+
MIT License
9 stars 6 forks source link

star light secondary color stuck on #00ff00 #31

Closed miromonti closed 3 years ago

miromonti commented 3 years ago

image

No matter how often I change the color, any color I choose, and with all other mods turned off, Star Light's secondary color reverts to #00ff00. Is this just me? Is there a conflict I should know about?

BlitzKraig commented 3 years ago

Hmm, that's definintely not right. I'll take a look when I'm working on the CL improvements

Thanks for the feedback!

miromonti commented 3 years ago

Update: Turns out the secondary color sticks when adjusting the on-scene token's vision. Secondary color via the character sheet is what reverts to #00ff00. So, not the worst thing; just the inconvenience of having to adjust the Star Light secondary color each time I place a token onto scene.

miromonti commented 3 years ago

Just discovered this issue also affects Star Light Disco. Don't know whether that's always been the case, but I suppose yes, given their similarity.

BlitzKraig commented 3 years ago

Hi miromonti, I've been chipping away at CL and have been easily able to replicate this, so a fix will be coming, though I'm unsure of the timeframe as my module dev time is limited at the moment.

Thanks for the additional info!

miromonti commented 3 years ago

No rush. I've learned to work around the issue. I look forward to your fix.

BlitzKraig commented 3 years ago

Hey, just so you know, this issue should be fixed in the foundry 0.8+ version of Community Lighting.

Let me know if you're having any issues with it

miromonti commented 3 years ago

Thanks for the update! Just so I'm clear, the issue is fixed for Foundry 0.8+, but remains for 0.7.x, correct?

BlitzKraig commented 3 years ago

Correct, it is likely still an issue in the final 0.7 update.

Depending on request volume, I may push a fix for 0.7, but doesn't seem worth it since most will be moving, or have already moved, to 0.8