support to v12 (it pottentially breaks compatibility to old versions

BlitzKraig / fvtt-SoundBoard

Gamemaster Soundboard for Foundry VTT

MIT License

20 stars 17 forks source link

support to v12 (it pottentially breaks compatibility to old versions #99

Open mrcomac opened 3 months ago

mrcomac commented 3 months ago

I made some changes to make the module work on v12. These changes may potentially break compatibility with older versions of FoundryVTT.

I saw issue 98 that you are happy to hand over the module to someone but actually, after these changes, you might not need to hand over this module to anyone until you decide whether you will continue working on it or not.

If you need assistance with fixing bugs, I'm happy to help. You need to HO this module I'm happy to keep working on it, and I'll be happy to HO back to you if you decide return to maintain it.

cheers Marcos, (Snagov on discord)

rociodiaz-sistemas commented 3 months ago

Hey! I'm more than happy to test this change and add a review, maybe we can reinforce visibility for the author. I'm a programmer, however, I'm not familiar with testing specific branches with changes on foundry. @mrcomac Would you be kind enough to explain?

mrcomac commented 3 months ago

@rociodiaz-sistemas you can test using this link https://github.com/piecesofcodecom/fvtt-SoundBoard/archive/refs/tags/teste.zip.

You can download and install manually.

Vafthrudnir commented 2 months ago

Hi, I've tested the change on v12, build 331, and it seems to work fine! Test details:

set up custom folder with several mp3 sounds, ordered into 3 folders
opened the soundboard -> it found all the sounds, ordered them into packs based on the folder names
played a sound by left clicking -> I've heard the sound as a GM, and the players heard the sound as well though their browsers
played a sound by right clicking -> Only I've heard the sound, the players didn't
used the volume control, worked fine as well