Blitzapps / blitz-orm

GNU Affero General Public License v3.0
23 stars 9 forks source link

Sweep: Improve error handling in SurrealDB benchmarking #68

Closed sweep-ai[bot] closed 3 months ago

sweep-ai[bot] commented 3 months ago

Purpose

This pull request addresses issues in the SurrealDB benchmarking setup by improving error handling in the initialization process and the benchmarking script.

Description

The changes in this pull request include:

  1. In the tests/surrealdb/bench/all.bench.ts file, the init function is now wrapped in a try-catch block to handle any errors that may occur during initialization. This ensures that any failures in the initialization process are properly reported and do not lead to unhandled exceptions.

  2. In the tests/bench.sh script, the Docker commands are now executed with the set -e flag, which causes the script to exit immediately if any command returns a non-zero exit code. This ensures that any failures in starting the SurrealDB container are properly reported and do not lead to silent failures or incomplete setups.

Summary

Fixes #67.


[!TIP] To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

This is an automated message generated by Sweep AI.

sweep-ai[bot] commented 3 months ago

Rollback Files For Sweep

This is an automated message generated by Sweep AI.