search

Blitzker / assfiltermod

DirectShow subtitle provider based on libass
GNU General Public License v3.0
76 stars 8 forks source link

Add VobSub support #2

Closed Keith94 closed 7 years ago

Keith94 commented 7 years ago

Tested with: [Doremi].Hatsune.Miku.Magical.Mirai.2016.[SEGA].[1920x1080].[Blu-ray].[8-bit].[0D860401].mkv

assfiltermod_harfbuzz_x3_x64 => Video loads but all subtitle tracks (including .ass) don't display

assfiltermod_harfbuzz_x4_x64 => madVR crashes when opening the file: Zugriffsverletzung bei Adresse $7f87c6c70c6 in Modul 'assfiltermod.dll'. Lesen von Adresse $70.

Blitzker commented 7 years ago

Please test with the latest release. This should be fixed.

Keith94 commented 7 years ago

I confirm it's fixed in 0.3. Will VOBSUB or HDMVSUB ever be supported?

Blitzker commented 7 years ago

Good, thanks for testing.

As for VOBSUB & PGS, i would like to eventually implement them but the problem is that there is no lightweight library (like libass) that support them. So porting the code from VSFilter would be the logical solution but its a lot of work.

I don't say i won't do it but i can't confirm it either.

Keith94 commented 7 years ago

OK - thanks for reply.

amayra commented 7 years ago

@Blitzker you can use VobSub/PGS code from MPC-HC or MPC-BE like @clsid said if i have free time i will help you with this

amayra commented 7 years ago

bytheway there difference between MPC-HC ISR and MPC-BE ISR you should keep this in your mind