Blitzker / assfiltermod

DirectShow subtitle provider based on libass
GNU General Public License v3.0
74 stars 8 forks source link

Broken external font loading #3

Open sibwaf opened 7 years ago

sibwaf commented 7 years ago

"External Subtitles Fonts Folder" setting doesn't do anything at all. Fonts are being loaded only from direct subdirectories of the directory with the video (fonts placed in the same directory as the video are ignored too, even if the setting is set to {FILE_DIR}), completly ignoring specified path.

I'm using MPC-BE 1.5.1 x64 and AssFilterMod 0.3 x64 on Windows 10.

Blitzker commented 7 years ago

It works fine here, even if the fonts are on a USB stick. Have you tried to start MPC-BE in administrator mode to see if its not a permission problem? Some users using Windows 10 had problems like this when the media player was installed on their boot drive.

sibwaf commented 7 years ago

Further testing shows very interesting things: 1) I'm an idiot (AssFilterMod really needs integration with MPC-BE or at least an instruction how to make them work together) 2) Loading fonts from subdirectories of video's directory was MPC-BE's internal subtitle renderer feature 3) Font loading works perfectly fine (though the recommended (required?) lack of the "\" character after {FILE_DIR} is kind of confusing) 4) AssFilterMod doesn't work when playing a video from a remote shared directory

So, I have a Samba server on a remote Linux host. And it works perfectly fine until I try to use AssFilterMod, because when it finds subtitles and tries to render them, the player just freezes completly, and it freezes so bad, that even Task Menager needs several minutes to kill the process. I tried running MPC-BE as administrator and got the same result. The freeze doesn't depend on the chosen subtitle renderer in the player and appears every time AssFilterMod tries to render.

The path to the video looks like \\REMOTE-HOST\Videos\Video.mp4

Blitzker commented 7 years ago

Trying to play a video on a remote computer is something i haven't tested so there is possibly some code that need to be tuned for network access. Thanks for the testing, i'll try to fix that problem soon.