search

Blizzard / heroprotocol

Python library to decode Heroes of the Storm replays
MIT License
397 stars 71 forks source link

'SScoreResultEvent' Self Healing sometimes applying to Healing #29

Open barrett777 opened 8 years ago

barrett777 commented 8 years ago

It looks like Thrall's 'SelfHealing' values are duplicated into his 'Healing' field as well. In the few replays I've looked at, these values match eachother in each game

Chen also has some 'Healing', as well as 'SelfHealing'. In a couple games I looked at, his 'SelfHealing' was around 15000, and 'Healing' was around 1000. Perhaps one of his talents' 'SelfHealing' or shielding is applying to 'Healing'

Looks like 'Li-Ming' can also have 'Healing' - a very small 94 in one game

There may be others, this is all I've found for now. If this is unintended, could you fix where these values are applied in a future build?

tenarsis commented 8 years ago

Thanks for bringing this discrepancy up.

barrett777 commented 8 years ago

Chen is probably fine, with his Healing coming from 'Enough to Share' talent that shields allies

I'm still not sure where Li-Ming's 'Healing' comes from. It may be from 'Diamond Skin', when her shield is actually damaged, though if this is the case, it should probably go under 'Self Healing.'

Thrall still doubles his 'Self Healing' by also adding it to 'Healing' in the current Machines of War PTR.

I don't know how you are coding things on your end, but I worry that Thrall's issue may unfairly give him the 'MVP' award more than he should get it.