Blizzard / node-rdkafka

Node.js bindings for librdkafka
MIT License
2.08k stars 391 forks source link

Allow passing null to commitSync in KafkaConsumer typings #1082

Closed Tapppi closed 4 days ago

Tapppi commented 3 weeks ago

In the typings KafkaConsumer incorrectly requires that commitSync be called with a TopicPartitionOffset or an array of TopicPartitionOffsets, when docs say that null can be passed to commit all read offsets. This change allows null to be passed without resorting to hacks like client.commitSync(null as any).