search

Blizzard / node-rdkafka

Node.js bindings for librdkafka
MIT License
2.1k stars 391 forks source link

Docs: fix alpine example due to python version #945

Closed cbrwflo closed 1 year ago

cbrwflo commented 2 years ago

Fixes the Alpine example, which removed the generic python package in v3.12.

node-gyp supports python3 since v5.x: https://github.com/nodejs/node-gyp/blob/master/CHANGELOG.md

iradul commented 2 years ago

Thank you for the PR. Could you also update the image from FROM node:8-alpine to FROM node:14-alpine?

cbrwflo commented 2 years ago

Sorry for the delay -- tested and this builds fine.