search

Blizzard / node-rdkafka

Node.js bindings for librdkafka
MIT License
2.1k stars 391 forks source link

add github action #946

Closed yunnysunny closed 1 year ago

yunnysunny commented 2 years ago

Since the trvais ci is not free now, and the test on travis is all been skiped. I rewrite the CI use github action.

It 's import to merge this request , since the tests is not tirggered when new code was merge to master.

cclauss commented 2 years ago

Node.js 8 seems to fail…. https://github.com/yunnysunny/node-rdkafka/actions

yunnysunny commented 2 years ago

Node.js 8 seems to fail…. https://github.com/yunnysunny/node-rdkafka/actions

Need to update node-gyp to a correct version on Node 8. I will try the 6.x version.

cclauss commented 2 years ago

Awesome!! Extra credit? Node.js 18 on Windows 22

yunnysunny commented 2 years ago

Awesome!! Extra credit? Node.js 18 on Windows 22

Node-gyp does not work on Windows 2022, https://github.com/yunnysunny/node-rdkafka/runs/7162913449?check_suite_focus=true . When I run update command on Windows 2022, it failed https://github.com/yunnysunny/node-rdkafka/runs/7162957526?check_suite_focus=true

We can consider merging the request of https://github.com/nodejs/node-gyp/pull/2684 to see the error detail of executing powershell script. @cclauss

GaryWilber commented 1 year ago

This was partly done in #978 and I added Windows & Mac to the matrix in #998. I think this can be closed now?