Update librdkafka from 1.8.2 -> 1.9.2

Blizzard / node-rdkafka

Node.js bindings for librdkafka

MIT License

2.11k stars 396 forks source link

Update librdkafka from 1.8.2 -> 1.9.2 #961

Closed GaryWilber closed 2 years ago

GaryWilber commented 2 years ago

Changes:

librdkafka 1.9.2
Update windows-install.py script due to path change related to MSVS v142 build tools
Minor update to librdkafka-defs-generator.js script to fix issues related to some new comments in the rdkafka c++ files

parkjh commented 2 years ago

@GaryWilber I'm not a maintainer who can approve this pr but I don't suppose librdkafka can be updated to 1.9.1? https://github.com/edenhill/librdkafka/releases/tag/v1.9.1 as a m1 laptop user, it'd be very much appreciated... 🙏

GaryWilber commented 2 years ago

@parkjh I updated it

robinfehr commented 2 years ago

we'd love to see that merged as well!

sharmakhushboo commented 2 years ago

@iradul could you please review this pr? We are also looking forward to consume this change.

sharmakhushboo commented 2 years ago

@webmakersteve may be you can help us with the review/merge here?

sharmakhushboo commented 2 years ago

@eandersson / @BlizzTom would you be able to help us here?

ahmedbisht commented 2 years ago

who can help merge this? thanks

hedasilv commented 2 years ago

@eandersson, @BlizzTom, @webmakersteve, who could help us get this pull request approved? We are looking forward to getting these updates in our app. Thanks a lot!

iradul commented 2 years ago

Thank you @GaryWilber !