Blizzard / node-rdkafka

Node.js bindings for librdkafka
MIT License
2.1k stars 391 forks source link

node-rdkafka 2.14.0 on registry.npmjs.org has wrong version inside package.json #981

Closed jmyersmsft closed 1 year ago

jmyersmsft commented 1 year ago

In the package.json inside https://registry.npmjs.org/node-rdkafka/-/node-rdkafka-2.14.0.tgz, the version is v2.14.2-1.HEAD. This causes problems with any system that uses or validates the version in the package-json, including the upstreams feature in Azure Artifacts.

sharmakhushboo commented 1 year ago

@webmakersteve @iradul , could you take a look at this?

sharmakhushboo commented 1 year ago

@eandersson / @BlizzTom would you be able to help us here?

ArneSchulze commented 1 year ago

+1

alexzel commented 1 year ago

+1

jancwiok commented 1 year ago

On github the version seems to be correct: https://github.com/Blizzard/node-rdkafka/releases/tag/v2.14.2 . But the one on npm registry is incorrect. This also cause that when running npm install --omit=dev still all the dev dependency from node-rdkafka are installed. This does not happen for version 2.13.0. Could anyone take a look at this?

shiyuanhai commented 1 year ago

+1

 ERR_PNPM_UNEXPECTED_PKG_CONTENT_IN_STORE  Package name mismatch found while reading {"integrity":"sha512-g/I6e1/07uuy3Tjeka7JKZDhbeKeDsX0P9Lj2gsZqsfqWXnwbEfLs3AaKs2/QPts62RWiXLoBhxI7W4cREZXyw==","registry":"https://registry.npmjs.org/","tarball":"https://registry.npmjs.org/node-rdkafka/-/node-rdkafka-2.14.0.tgz"} from the store. This means that the lockfile is broken. Expected package: node-rdkafka@2.14.0. Actual package in the store by the given integrity: node-rdkafka@2.14.2-1.HEAD.

got this error using pnpm.

monil-panchal commented 1 year ago

The v2.14.0 in npm registry seems to be correct, whereas the v2.14.2 on Github is not.

image

image

alexzel commented 1 year ago

Well, the latest available version in npm is v2.14.0 and there is v2.14.2-1.HEAD inside the tarball.

$ npm view node-rdkafka dist.tarball
https://registry.npmjs.org/node-rdkafka/-/node-rdkafka-2.14.0.tgz

$ curl -s -O -J https://registry.npmjs.org/node-rdkafka/-/node-rdkafka-2.14.0.tgz

$ tar xzf node-rdkafka-2.14.0.tgz

$ jq .version package/package.json
"v2.14.2-1.HEAD"
AlexVasiukov commented 1 year ago

Are there any updates for it? The issue is still reproducible.

aikoven commented 1 year ago

As a temporary solution, I've published corrected package as @aikoven/node-rdkafka@2.14.0.

JackFreelander commented 1 year ago

This is still broken for me and using pnpm this causes errors during package install. @webmakersteve any ETA on a fix, perhaps a clean 2.15 build?

GaryWilber commented 1 year ago

I made a fix for this. Can you try version 2.14.4 - https://www.npmjs.com/package/node-rdkafka/v/2.14.4

alexzel commented 1 year ago

Thanks for the fix! Version 2.14.5 works well.

sharmakhushboo commented 1 year ago

This issue has now been fixed in the new version.