missing cmake INSTALL target

Blizzard / s2client-api

StarCraft II Client - C++ library supported on Windows, Linux and Mac designed for building scripted bots and research using the SC2API.

MIT License

1.66k stars 282 forks source link

missing cmake INSTALL target #232

Closed T-Jin closed 6 years ago

T-Jin commented 6 years ago

Cmake INSTALL target doesn't actually install built sc2api libs to CMAKE_INSTALL_PREFIX location. Dependent libs (like protobuf and civetweb) does get copied over, but not sc2api.lib, ac2lib.lib, etc.

Is this intended behavior? Add the install target to cmakelist inside ./src?

Tested on win10 x64 with vs2017

alkurbatov commented 6 years ago

Hi @T-Jin . It had been implemented by @kuzi117 about a month ago, see #206

T-Jin commented 6 years ago

Cool. Hope the fix get merged soon.