Starport & cloak research issue

Blizzard / s2client-proto

StarCraft II Client - protocol definitions used to communicate with StarCraft II.

MIT License

3.8k stars 432 forks source link

Starport & cloak research issue #113

Open Evan-Kim2028 opened 6 years ago

Evan-Kim2028 commented 6 years ago

Hello, I recently added some code into my python-sc2 library based bot and when banshee cloak started to research, my starport lifted up but cloak continued to research and eventually finished.

Seems to be a bug


        for sp in self.units(STARPORTTECHLAB).ready.noqueue:
            if not self.already_pending_upgrade(BANSHEECLOAK) and self.can_afford(BANSHEECLOAK):
                print("researching cloak!")
                self.combinedActions.append(sp.research(BANSHEECLOAK))```

ttinies commented 6 years ago

This is an issue for python-sc2, not s2client-proto.

I believe the SC2 correct ability to invoke researching banshee cloak is # 790.