search

Blizzard / s2client-proto

StarCraft II Client - protocol definitions used to communicate with StarCraft II.
MIT License
3.78k stars 431 forks source link

Add air/ground for UnitType Data #140

Open neoedmund opened 5 years ago

neoedmund commented 5 years ago

Missing raw data to see a unittype is a air or ground one?

tweakimp commented 5 years ago

It is right here

neoedmund commented 5 years ago

Okay, thanks! I see some unit like viking can also fly and go to ground.

tweakimp commented 5 years ago

These are two different units. VIKINGASSAULT and VIKINGFIGHTER

neoedmund commented 5 years ago

Then it still be more clear if an air/ground type added in the UnitType?

tweakimp commented 5 years ago

This question was answered in my first post. There is already a boolean to determine that.

neoedmund commented 5 years ago

I mean a UnitType is determined to be air or ground, so there should be a field indicate it, for clarify. A Unit is fly just because its type is fly. so the fly should be moved to UnitType actually.

tweakimp commented 5 years ago

No. If you lift a marine with a phoenix, the marine is now flying. you cant change its unit type in that situation.

neoedmund commented 5 years ago

But for writing bot, you have a need to filter out air units from UnitTypes. like Phoenix is air, Observer is air, we need somewhere to tell it, of course I can make a full list of air unit names, but it can be avoid, that is what DATA for.