search

Blizzard / s2client-proto

StarCraft II Client - protocol definitions used to communicate with StarCraft II.
MIT License
3.76k stars 431 forks source link

Add a proto equivalent to sc2_typeenums.h #16

Open Databean opened 6 years ago

Databean commented 6 years ago

https://github.com/Blizzard/s2client-api/blob/master/include/sc2api/sc2_typeenums.h

As sc2_typeeenums.h says, "All units and abilities are represented as unsigned numbers in the StarCraft II engine. This can make issue abilities unnecessarily hard."

This fact is also true with the proto API. As it is, any equivalent implementation of the sc2api client in another language will have to define its own equivalent of these enums, or force its users to figure out the unit indexes themselves.

Is it possible to define this as a protobuf enum as part of the protocol sent by the game?

AnthonyBrunasso commented 6 years ago

We definitely agree with you and have added this as something we will implement. We're not sure what the timeline will be on it though.

Thanks for bringing this up.

carlos-sarmiento commented 6 years ago

Any update on this?