Using camera_move action in feature layer is inaccurate

[islamelnabarawy]

Summary: The camera_move action introduces inaccuracy between the center of the camera feature in the minimap and the point that was passed as an argument to camera_move. The bigger the map, the more inaccurate it gets.

This jupyter notebook illustrates the issue.

The inaccuracy is probably coming from the way the camera feature layer itself is generated, but it manifests very clearly when the center of the camera rectangle is used as an argument to camera_move.

Steps to reproduce:

• Initialize the API and connect to the feature layer, then start a new game using any map
• Use the camera feature from the minimap to calculate the center of the camera rectangle on the minimap
• Use the camera_move action to move the camera to that calculated point

Expected result:

• Camera shouldn't move and center of camera feature should remain unchanged.

Actual result:

• Camera drifts slightly towards the top-left corner
• Repeating the last two steps causes the camera to continue drifting towards the top-left corner

[islamelnabarawy]

Turns out this was due to the fact that the size of the minimap is even, and when getting the center I was rounding down the 0.5. When I get the ceiling instead, the issue doesn't happen.

In case anyone else runs into the same problem, the solution is to round up instead of down when calculating the camera position using the camera feature. That gets rid of the issue.