Blizzard / s2protocol

Python library to decode StarCraft II replay protocols
MIT License
621 stars 111 forks source link

Bad gameloop values in replays from loaded/saved games #22

Open dsjoerg opened 10 years ago

dsjoerg commented 10 years ago

If you save a game, and then load it and play it, the resulting replay file has events with bad _gameloop values (e.g. 4294970998). They are bad in that they are huge numbers with some very high-order bits set.

Example replay: https://dl.dropboxusercontent.com/u/556553/put_things_here/s2protocol_issue.SC2Replay

Demonstration of the problem: https://gist.github.com/dsjoerg/c75ae52ce8099b430ee5

Perhaps the solution is to simply mask out the higher-order bits of the gameloop? That's what I did in sc2reader: https://github.com/GraylinKim/sc2reader/commit/c860d8e23d6fbd3a9258deff9fcbe8796da6c900

jrepp commented 7 years ago

Sounds like it's a negative number. I'll see about getting an internal bug filed for this.