search

BlocSoc-iitr / selene

A fast & portable light client for Ethereum in Golang.
4 stars 5 forks source link

Implement/consensus/rpc #16 #21

Closed x-senpai-x closed 2 weeks ago

x-senpai-x commented 2 weeks ago

Implemented consensus_rpc.go, nimbus_rpc.go,mock_rpc.go .In mock_rpc.go used the testdata of helios and added it here in testdata folder , made a folder consensus/consensus_core to define the structs

x-senpai-x commented 2 weeks ago

@star-gazer111 please review this

gerceboss commented 2 weeks ago

I think we need to split this PR in two parts, one which adds data(json) and other adding the code logic. What's your take on this ? @star-gazer111

star-gazer111 commented 2 weeks ago

I think we need to split this PR in two parts, one which adds data(json) and other adding the code logic. What's your take on this ? @star-gazer111

I think we can go ahead with this only for now.

gerceboss commented 2 weeks ago

LGTM as well, merging the @x-senpai-x , just mention while making the PR if you are adding any constant values referencing to helios