search

BlockHorizons / FactionsPE

Most advanced factions plugin for PocketMine-MP
GNU General Public License v3.0
47 stars 42 forks source link

TODO #1

Open Kris-Driv opened 7 years ago

Kris-Driv commented 7 years ago
Sandertv commented 7 years ago

Make sure to tell me if I can help with anything.

Kris-Driv commented 7 years ago

MySQL support is kinda useless at this point. Kinda same issue when you try to push a commit without fetching repository. No idea how to explain it correctly :smile:

Kris-Driv commented 7 years ago

I made MySQL support in lazy style, saving arrays (permissions, members, flags etc.) as json strings instead of new tables. Saying in case you feel like correcting it

Thunder33345 commented 7 years ago

well you can put it in projects todo a new tab for people who have too many time on hands to fix it

Thunder33345 commented 7 years ago

it would also be nice to document more things this pugin seems quite big and promising so API docs for other devs to build compatibility will be nice

Kris-Driv commented 7 years ago

@Thunder33345 working on commenting stuff and creating API docs along with wiki.

Sandertv commented 7 years ago

I'm just gonna go ahead and make a Gitter chat room for the organization. That'll make talking a bit easier.

Kris-Driv commented 7 years ago

@Sandertv sure, and add the link with gitter badge to readme.

Kris-Driv commented 7 years ago

Plugin will be v1.0.0 when this list is complete.

Thunder33345 commented 7 years ago

actually doing a pre release would be nice a dev build using poggit would be nice too

Grab the latest .phar file from release section and insert into your server's plugin folder

but there's no phar or releases!

Sandertv commented 7 years ago

@Chris-Prime I'll take a look and see if I can improve the MySQL implementation.

Sandertv commented 7 years ago

Added info command to the TODO list..

asyncthreading commented 7 years ago

@Sandertv @Chris-Prime Maybe add DTR?

Kris-Driv commented 7 years ago

What's that? @akaSnapy

Oh, if you're speaking about relationships then it's already implemented. /f relation

asyncthreading commented 7 years ago

DTR=Deaths To Raidable. 1member means x/1 DTR 2 members = x/2 DTR etc.. If you're on 1 DTR and you/other member die this means you went "Raidable" so everyone can bypass your claim until the dtr regens back.

asyncthreading commented 7 years ago

Or each value from 0.01-1DTR

Kris-Driv commented 7 years ago

Sounds good, but I don't think I will be implementing this into core. I could make it into separate plugin. But I still don't get the mechanics could you elaborate more by creating new issue?

asyncthreading commented 7 years ago

Here's how it would work. You would calculate how much DTR a faction gets by dividing its players by 2, for example, a 15 man faction would get a maximum of 7.5 DTR. That means when 8 people die, the faction goes raidable.

When a faction is raidable, enemy factions can edit terrain, open chests, kill mobs, etc on there claimed land.

DTR regenerates slowly, so if a faction got to 1 DTR, they could safely wait it out and they would get back up to their max DTR. A faction that goes raidable could do this too, but when they go raidable, there is a "DTR Freeze" where they stop regenerating, this should last about 2.5 hours.

asyncthreading commented 7 years ago

@Chris-Prime

asyncthreading commented 7 years ago

The DTR freezing can be configurated also

Sandertv commented 7 years ago

That's quite an interesting concept.

asyncthreading commented 7 years ago

If your faction's DTR goes below 0, you are raidable. The DTR freeze is the time after a death until you will be able to regenerate DTR. If you are raidable, your DTR will still regenerate after the DTR freeze time (configurable) and once it goes above 0, you will no longer be raidable.

asyncthreading commented 7 years ago

this can be also selected if its on or no. factions-dtr=false/true