BlockHorizons / PerWorldInventory

A full-featured per world inventory plugin for PocketMine-MP.
https://poggit.pmmp.io/p/perworldinventory
Apache License 2.0
14 stars 10 forks source link

Rewritten some parts and made read/write asynchronous and update to ALPHA11/12 #9

Closed Muqsit closed 6 years ago

Muqsit commented 6 years ago

Before trying this out, let me just say that this is a BACKWARDS INCOMPATIBLE commit. Your old PerWorldInventory data will still be safe, but won't be read. NOTE: This is a backwards-incompatible update. If you have old inventory files in plugins/PerWorldInventory/inventories folder, you can run /pwi updateoldfiles command to convert the old (.yml) files to the new (.dat) format. After that, you can optionally get rid of all the .yml files in the directory as they aren't going to be read by the plugin anymore. Sample output of the command:

[09:16:08] [Server thread/INFO]: Updating old files...
[09:16:08] [Server thread/INFO]: Updated muqsitrayyanxo.yml
[09:16:08] [Server thread/INFO]: Update finished. Updated (1) files.

What does this pull request add?

FAQs Q. Since the inventories are read asynchronously, what happens if the player completely logs in while the inventory contents are still being read? A. The plugin will cancel ALL InventoryTransactionEvent calls received from the player.

Sandertv commented 6 years ago

Ready to merge?

Muqsit commented 6 years ago

@Sandertv Yup.

Muqsit commented 6 years ago

I'll merge it after doing some more tests.