search

BlockPo / BlockPo-to-Tradelayer

Incubation Repo for the TradeLayer protocol, 0.2.0
http://www.tradelayer.org
Other
8 stars 8 forks source link

remove allPrice and fix tl_getmax_peggedcurrency #202

Closed Galuf1 closed 4 years ago

Galuf1 commented 4 years ago

the logic to get the max pegged currency, or to check how much short contracts you need vs the collatera should be revisited. In tl_getmax_peggedcurrency to calculate the max pegged currency that we use in the wallet it adds a hardcoded All price in dollars, which we used for a demo and now it doesn't make sense.

patrickdugan commented 4 years ago

Please mark these tickets under the Testnet Native Release Milestone, if it's not essential to functioning margin/settlement/fees/insurance/Oracle operations, it's not going in this month's release.

On Tue, Mar 10, 2020 at 10:48 AM Galuf1 notifications@github.com wrote:

the logic to get the max pegged currency, or to check how much short contracts you need vs the collatera should be revisited. In tl_getmax_peggedcurrency to calculate the max pegged currency that we use in the wallet it adds a hardcoded All price in dollars, which we used for a demo and now it doesn't make sense.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BlockPo/BlockPo-to-Tradelayer/issues/202?email_source=notifications&email_token=AAS2CBKMPYLSSTB74SKYWQDRGZAMPA5CNFSM4LE7JY7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IT4T2LQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS2CBNXPHFH7INZNM5QJYLRGZAMPANCNFSM4LE7JY7A .

Galuf1 commented 4 years ago

done