search

BlockPo / BlockPo-to-Tradelayer

Incubation Repo for the TradeLayer protocol, 0.2.0
http://www.tradelayer.org
Other
8 stars 8 forks source link

rounding in dex and metadex #258

Closed Galuf1 closed 4 years ago

Galuf1 commented 4 years ago

we have to revisit the rounding in dex and metadex, check what the logic is, unit test if it's consistent and check what's the precision we need. Also check for overflows in those unit tests, anything that involves divisions.

santos177 commented 4 years ago

Closing this ticket after DEx and MetaDEx testing. For now math seems ok using uint256 arithmetic (in multiplication and divisions) and a clean treatment using integers. This ticket could be reopen if we find inconsistency using doubles in different machines/ OS. Travis CI can help with that.