BlockPo / BlockPo-to-Tradelayer

Incubation Repo for the TradeLayer protocol, 0.2.0
http://www.tradelayer.org
Other
8 stars 8 forks source link

Possible infinite recursion in ParseAmountContract(); #336

Closed philmb3487 closed 4 years ago

philmb3487 commented 4 years ago

` -int64_t ParseAmountContract(const UniValue& value, int propertyType) -{

int64_t ParseAmountContract(const UniValue& value, int propertyType); int64_t ParseAmountContract(const UniValue& value); `

I am not sure what the intent is here, but in any case there's a potential (actually certain) infinite loop here because there's no override with the bool argument. Possibly we should refactor ParseAmount a bit to avoid this confusion.

santos177 commented 4 years ago

Absolutely , very nice catch! @sinetek. We are not using that function anymore, but i have to delete from an unit tests file.