search

BlockPo / BlockPo-to-Tradelayer

Incubation Repo for the TradeLayer protocol, 0.2.0
http://www.tradelayer.org
Other
8 stars 8 forks source link

KYC Valid vs. Logic Valid #343

Closed patrickdugan closed 4 years ago

patrickdugan commented 4 years ago

One confusing thing about our current default tx info is that you can have enough balance to do a send or trade, but it can be invalid due to KYC, and there is no error message or hint of this.

Therefore I propose we change the isValid field in the JSON returned by the tx info RPC, to be called logicValid: <true/false> and then add an additional field, KYCValid: <true/false> in regards specifically to the validity criteria of KYC attestations.

santos177 commented 4 years ago

I wrote a minimalist code: same isValid field and a new field: "invalidation reason". That should be enough information in order to see what happened with some particular transaction. Of course, we can add more things in the future if we need it.

patrickdugan commented 4 years ago

That's more elegant!

On Mon, Sep 21, 2020 at 1:19 PM Santos notifications@github.com wrote:

Closed #343 https://github.com/BlockPo/BlockPo-to-Tradelayer/issues/343.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BlockPo/BlockPo-to-Tradelayer/issues/343#event-3789515496, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS2CBPZYYVEHAZS6OYI7Y3SG54H5ANCNFSM4RQ5ZD4A .