search

BlockPo / BlockPo-to-Tradelayer

Incubation Repo for the TradeLayer protocol, 0.2.0
http://www.tradelayer.org
Other
8 stars 8 forks source link

tl_getbalanceRPC returns confusing err #387

Closed patrickdugan closed 3 years ago

patrickdugan commented 4 years ago

When I use the original RPC for BTC (or LTC) balance on a naked (new) address I get:

root@localhost:~# litecoin-cli getbalance mi7aba7XLRTLoxjgXvYeangjcSQTWWjiA2 0.00000000

When I use our tl_getbalanceRPC with no balance the response is:

error code: -8 error message: Address not found

This is somewhat confusing.

Because I'm gagging to get a proper release out I've assigned this for Oracle Testnet as housekeeping before the next release.

Should return an empty JSON array if no balances are available.

Same should apply for the tl_getpositions RPC.

Noting that the RPC requires an additional parameter of the specific property id, so in that case the err should be a prompting of the RPC parameter info.

patrickdugan commented 3 years ago

On review, this is probably fine as is and we could close.